[FLINK-39879][tests] Avoid deploy RPC timeout in CheckpointAcknowledgeFailureITCase#28377
Open
MartijnVisser wants to merge 1 commit into
Open
Conversation
…eFailureITCase The oversized checkpoint ACK can never be delivered (state is 2x the pekko frame size), so it always surfaces as an AskTimeoutException. The same cluster-wide ask timeout also covers task deployment, which flaked on slow CI at 250 ms. Raise it to 1 s; the failure mode is unchanged and CHECKPOINT_TIMEOUT stays ask-timeout x 1000. Generated-by: Claude Opus 4.8 (1M context)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
CheckpointAcknowledgeFailureITCase.testCheckpointAckFailurestill fails on slow CI after the hang fix. The 250 mspekko.ask.timeoutset by the test is load-bearing (it forces the oversized checkpoint ACK to time out, which the test asserts on), but it is the cluster-wide RPC timeout and therefore also governs task deployment. On a slow machine the deployment ask itself exceeds 250 ms, so the job fails (recovery suppressed byNoRestartBackoffTimeStrategy) before the keyed state is updated.Brief change log
ASK_TIMEOUTfrom 250 ms to 1 s.CHECKPOINT_TIMEOUTstaysASK_TIMEOUT * 1000, so the oversized ACK is still what times out and theAskTimeoutExceptionassertion is unchanged, while task deployment gets headroom on slow CI.Verifying this change
This change is already covered by the existing
testCheckpointAckFailureassertion (theAskTimeoutExceptioncheck is unchanged); it only removes a slow-CI deploy-timeout flake. Verified by running the test repeatedly locally.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.8 (1M context)